RFR: JDK-8199700: SA: Enable jhsdb jtreg tests for Mac OS X

[David Holmes]

Hi Jini,

There are quite a few changes to digest in this - it may have been 
better to break them up individually:
- sudo use
- refactor to use ClshdbLauncher
- changes to use regex matching

Focusing on the main sudo change the assumption is that on OSX you can 
run sudo without needing to provide a password - correct? That may be 
the case in mach5 but I'm not sure how others will go running these 
tests either in their test farms or locally.

I'm not sure about the regex changes from contains to matches - won't 
you need additional wildcards at the start and end of the strings to 
allow the string to be embedded in a longer string ??

Thanks,
David

PS. I start vacation in 48 hours :)

On 11/07/2018 12:38 PM, Jini George wrote:
> Gentle reminder !
> 
> Thanks,
> Jini.
> 
> On 7/10/2018 12:14 AM, Jini George wrote:
>> Requesting reviews for enabling SA tests on OS X for Mach5.
>>
>> https://bugs.openjdk.java.net/browse/JDK-8199700
>>
>> Webrev: http://cr.openjdk.java.net/~jgeorge/8199700/webrev.00/
>>
>> The changes are mostly to include the addition of sudo privileges to 
>> the SA launchers for OSX if Platform.shouldSAAttach() fails. Some 
>> tests (those using clhsdb) have been refactored to use ClhsdbLauncher 
>> for ease of maintainence. This also avoids checks for 
>> Platform.shouldSAAttach() for corefile related test cases. More 
>> details have been provided in JIRA.
>>
>> Thanks,
>> Jini.