RFR (S) 8205725: Update the JVMTI Spec for Heap Sampling

JC Beyler jcbeyler at google.com
Thu Jul 12 20:45:03 UTC 2018


Hi all,

Could I get a review of an update to the JVMTI Spec for Heap Sampling:
http://cr.openjdk.java.net/~jcbeyler/8205725/webrev.03/

The assoicated bug is here: https://bugs.openjdk.java.net/browse/JDK-8205725
The associated CSR is here: https://bugs.openjdk.java.net/browse/JDK-8206940

The basic reasoning of this webrev/bug/CSR is:
- rate is not the right word and should be renamed to interval, this is
what provokes the change in the code/tests/API naming.
- the spec does not mention that the new sampling interval will take time
to be taken into account (you have to wait for a TLAB to be refilled); this
adds that precision so that the user is not surprised
- the spec explicitly says that the sampling is done via a geometric
variable which averages to the sampling interval; it was asked to relax
this and the spec should just say that the sampling is pseudo-random and
the interval will average out to what the user requested.

Thanks for all your help,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20180712/f74207ea/attachment.html>


More information about the serviceability-dev mailing list