RFR: JDK-8206013: vmTestbase/nsk tests should have /timeout configured

[Chris Plummer]

Hi Gary,

It looks like you have properly added timeout=300 wherever we use 
-waittime:5. However, I'm not 100% convinced this is always the right 
approach. In the bug description you said that -waittime is used as a 
timeout for individual operations. However, there could be multiple of 
those operations, and they could in sum exceed the 300 second jtreg 
timeout you added.

What is the default for -waittime? I'm also guessing that the initial 
application of -waittime was never really tuned to the specific tests 
and just cloned across most of them. It seems every test either needs 5m 
or the default, which doesn't really make much sense. If 5m was really 
needed, we should have seen a lot of failures when ported to jtreg, but 
as far as I know the only reason this issue got on your radar was due to 
exclude001 needing 7m. Maybe rather than adding timeout=300  you should 
change -waitime to 2m, since other than exclude001, none of the tests 
seem to need more than 2m.

Lastly, does timeoutFactor impact -waittime? It seems it should be 
applied to it also. I'm not sure if it is.

thanks,

Chris

On 7/13/18 4:29 AM, Gary Adams wrote:
> This is a simple update to set the jtreg timeout to match the
> internal waittime already being used by these vmTestbase/nsk/jdb tests.
>
>   Issue: https://bugs.openjdk.java.net/browse/JDK-8206013
>   Webrev: http://cr.openjdk.java.net/~gadams/8206013/webrev.00/