RFR: 8206456 - [TESTBUG] docker jtreg tests fail on systems without cpuset.effective_cpus / cpuset.effective_mem

mandy chung mandy.chung at oracle.com
Wed Jul 18 00:07:03 UTC 2018



On 7/17/18 7:00 AM, Bob Vandette wrote:
> Please review this fix which eliminates some docker/cgroup test failures when running on older
> Linux kernels with missing cgroup metric files.
> 
> BUGS:
> https://bugs.openjdk.java.net/browse/JDK-8206456
> 
> WEBREV:
> http://cr.openjdk.java.net/~bobv/8206456/webrev/

Nit: It would be clearer to check for the specific metrics:

int[] cpusets = metrics.getEffectiveCpuSetCpus();
if (cpusets.length != 0) {
     ....
}

Same applies to getEffectiveCpuSetMems.  No need for a new webrev.

Mandy
P.S. I am not sure the conversion from the primitive to boxed type
is necessary.  But this is not related to this issue.  You may
want to take a look at that.


More information about the serviceability-dev mailing list