RFR(S) 8205652: serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatRateTest.java fails
JC Beyler
jcbeyler at google.com
Wed Jul 18 00:54:26 UTC 2018
Hi all,
Here is the webrev:
http://cr.openjdk.java.net/~jcbeyler/8205652/webrev.02/
Thanks for the reviews and future push!
Jc
On Tue, Jul 17, 2018 at 2:29 PM Alex Menkov <alexey.menkov at oracle.com>
wrote:
> +1
>
> --alex
>
> On 07/16/2018 12:58, serguei.spitsyn at oracle.com wrote:
> > Hi Jc,
> >
> > It looks good to me.
> >
> > Thanks,
> > Serguei
> >
> > On 7/16/18 10:58, JC Beyler wrote:
> >> Hi all,
> >>
> >> Small RFR to update a HeapMonitor test that had two issues: a test was
> >> wrong and the test was not allocating enough to get to an expected
> >> sample count. Instead of allocating 10 times more and hit some OOM on
> >> the test framework, the webrev allocates in chunks and gets the number
> >> of samples.
> >>
> >> I ran this 10k times on my machine and it passed. Serguei ran mach5
> >> testing with it and said it looked good.
> >>
> >> Bug associated is: JDK-8205652
> >> <https://bugs.openjdk.java.net/browse/JDK-8205652>
> >> Webrev is here:
> >> http://cr.openjdk.java.net/~jcbeyler/8205652/webrev.01/
> >> <http://cr.openjdk.java.net/%7Ejcbeyler/8205652/webrev.01/>
> >>
> >> Thanks,
> >> Jc
> >
>
--
Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20180717/83cfa9d9/attachment.html>
More information about the serviceability-dev
mailing list