RFR(S) 8207765: HeapMonitorIntervalRateTest fails with ZGC

[JC Beyler]

Hi Dan,


serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatRateTest.java
became
serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatIntervalTest.java,
when we updated the spec and said "rate" was the wrong word.

So yes, it fixes both since at some point all branches should see that the
StatRate test becomes renamed into the StatInterval test. Does that make
sense?

Thanks!
Jc


On Thu, Jul 19, 2018 at 9:45 AM Daniel D. Daugherty <
daniel.daugherty at oracle.com> wrote:

> JDK-8207765 covers two different tests as of yesterday:
>
> serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatRateTest.java
>
> and
>
> serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatIntervalTest.java
>
> I updated it to add a similar failure mode sighting for
> HeapMonitorStatIntervalTest.java
>
>
> Does your fix address both test failures?
>
> Dan
>
>
> On 7/19/18 12:39 PM, JC Beyler wrote:
>
> Hi all,
>
> Could I have a few reviews of:
> http://cr.openjdk.java.net/~jcbeyler/8207765/webrev.00/
>
> The  test assumed the size of a 1-element array but ZGC changes that
> assumption. The test now first allocates a bit of memory and gets the
> average size of the samples before assuming the size. This works
> with/without ZGC.
>
> Webrev: http://cr.openjdk.java.net/~jcbeyler/8207765/webrev.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8207765
>
> Thanks!
> Jc
>
>
>

-- 

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20180719/03925203/attachment.html>