[8u-backport] RFR: JDK-8191948: jdb error: InvalidTypeException: Can't assign double[][][] to double[][][]

[Fairoz Matte]

Hi Chris and Serguei,

Thanks for the review, I will add the appropriate noreg label.

Thanks,
Fairoz


From: Serguei Spitsyn 
Sent: Wednesday, July 25, 2018 11:24 PM
To: Chris Plummer <chris.plummer at oracle.com>; Fairoz Matte <fairoz.matte at oracle.com>; serviceability-dev at openjdk.java.net
Subject: Re: [8u-backport] RFR: JDK-8191948: jdb error: InvalidTypeException: Can't assign double[][][] to double[][][]

Hi Fairoz,

Looks good to me too.
Thank you for taking care about this backport!

On 7/25/18 10:31, Chris Plummer wrote:
Hi Fairoz, 

The changes look good. I'm not sure what the policy is when part of the (full) backport contains test changes that aren't directly applicable to 8u. You might need some sort of noreg label on the backport CR.

The test test/hotspot/jtreg/vmTestbase/nsk/jdb/eval/eval001 is located in the VM testbase which is a separate repository for jdk 8.
I agree with Chris, noreg label on the backport CR is probably needed.

Thanks,
Serguei



thanks, 

Chris 

On 7/25/18 1:23 AM, Fairoz Matte wrote: 

Hi, 

Kindly review the backport of "JDK-8191948: jdb error: InvalidTypeException: Can't assign double[][][] to double[][][]" to 8u 

Webrev - http://cr.openjdk.java.net/~fmatte/8191948/webrev.00/ 

JDK 11 bug - https://bugs.openjdk.java.net/browse/JDK-8191948 

JDK 11 changeset - http://hg.openjdk.java.net/jdk/jdk11/rev/73c769e0486a 

Review thread - http://mail.openjdk.java.net/pipermail/serviceability-dev/2018-July/024405.html

Thanks, 
Fairoz 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20180725/43c96334/attachment.html>