RFR (trivial) 8208074: [TESTBUG] vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption/TestDescription.java failed with NullPointerException

[serguei.spitsyn at oracle.com]

Hi Coleen,

The explanation from David is very helpful - thanks!
So the fix looks good to me as well.

We still need to answer questions from Chris though.

Thanks,
Serguei


On 7/30/18 14:46, David Holmes wrote:
> On 31/07/2018 6:49 AM, coleen.phillimore at oracle.com wrote:
>> Summary: fixed refactoring caused by JDK-8203820
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8208074.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8208074
>
> For the sake of other readers who don't want to have to reverse 
> engineer the actual cause of the problem, the original code has two 
> Method.invoke sequences: one for a static method and which passed a 
> null receiver; one  for a non-static method which passed a non-null 
> receiver. The refactoring extracted the invoke logic but always passed 
> a null receiver - which was wrong for the non-static case. The fix 
> always passes a non-null receiver to fix the non-static case, and 
> which is ignored in the static case.
>
> Reviewed. Trivial.
>
> Thanks,
> David
>
>> Ran the test in mach5 on all Oracle supported platforms.  Also took 
>> the test out of ProblemList.txt because JDK-8203820 fixes 
>> https://bugs.openjdk.java.net/browse/JDK-8202896.
>>
>> Thanks,
>> Coleen