RFR: 8204168: Increase small heap sizes in tests to accommodate ZGC

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Tue Jun 5 19:01:22 UTC 2018


I included the serviceability-dev list for the jdi tests.  I don't think 
this change increases the heap for these tests enough to cause any 
problems, so I think this change is fine.
thanks,
Coleen

On 6/5/18 5:27 AM, Erik Helin wrote:
> On 05/31/2018 02:32 PM, Stefan Karlsson wrote:
>> Hi all,
>
> Hey Stefan,
>
>> Please review this patch to increase the heap size for tests that 
>> sets a small heap size.
>>
>> http://cr.openjdk.java.net/~stefank/8204168/webrev.01
>> https://bugs.openjdk.java.net/browse/JDK-8204168
>
> I read through each test in compiler, gc and runtime carefully to 
> check that the increased heap size wouldn't render the test useless 
> (i.e. I ensured that the tests still test something). Good news, it 
> seems (to me at least) that increasing the heap size for all of the 
> above tests will work fine. Please consider the changes to those tests 
> Reviewed by me, nice work!
>
> Unfortunately I don't know the "nsk" tests well enough to review those 
> changes... :(
>
> Thanks,
> Erik



More information about the serviceability-dev mailing list