RFR(s): 8204243: remove Thread.destroy() and Thread.stop(Throwable)

[David Holmes]

Hi Stuart,

This all looks fine to me.

One minor nit in threadPrimitiveDeprecation.html is whether the new 
statements you reference a particular Java version? It reads a little 
oddly to go through all the explanation and then say "Thread.x has been 
removed". In the spirit of @since you might say "has been removed as of 
JDK 11". Or arguably you could remove discussion of the removed methods 
altogether.

Thanks,
David

On 6/06/2018 10:05 AM, Stuart Marks wrote:
> [adding serviceability-dev]
> 
> Hi serviceability folks,
> 
> I'm in the process of removing Thread.destroy() and 
> Thread.stop(Throwable) from the Java SE API. Alan and David have pointed 
> out that there are some cross-references to Thread.stop(Throwable) in 
> the JDWP and JVMTI specs, as well as in the JDI ThreadReference API. 
> I've adjusted the relevant files.
> 
> See please review this updated webrev:
> 
>      http://cr.openjdk.java.net/~smarks/reviews/8204243/webrev.1/
> 
> For context, please see the full review thread on core-libs-dev:
> 
>      
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2018-June/053536.html
> 
> 
> 
> On 6/4/18 11:11 PM, Alan Bateman wrote:
>> The source file that is used to generate the JDWP protocol code and 
>> the spec is in make/data/jdwp/jdwp.spec. The JVM TI spec is at 
>> src/hotspot/share/prims/jvmti.xml. It should be okay to skip those for 
>> this change-set, assuming it is followed up quickly with another 
>> change-set to update those specs.
> 
> OK. I took a look at those other files and they seem simple enough to 
> update as part of this changeset. If there aren't any objections from 
> anyone, might as well get this all done at once.
> 
> Thanks,
> 
> s'marks