RFR(S): 8204654: [testbug] Fix pattern matching in jstat tests.
Langer, Christoph
christoph.langer at sap.com
Wed Jun 13 08:32:55 UTC 2018
Hi Goetz,
this looks good to me. Thanks for making these tests more robust.
Best regards
Christoph
> -----Original Message-----
> From: serviceability-dev [mailto:serviceability-dev-
> bounces at openjdk.java.net] On Behalf Of Lindenmaier, Goetz
> Sent: Montag, 11. Juni 2018 15:15
> To: serviceability-dev (serviceability-dev at openjdk.java.net) <serviceability-
> dev at openjdk.java.net>
> Subject: [CAUTION] RFR(S): 8204654: [testbug] Fix pattern matching in jstat
> tests.
>
> Hi,
>
> please review this test fix:
> http://cr.openjdk.java.net/~goetz/wr18/8204654-fixJstatTest/01
>
> gcCauseOutput1.awk:
> The pattern scans 11 numbers, while the output contains 13. Also, more '-'
> are possible then checked.
>
> The other awk scripts need to check more patterns where '-' can appear.
>
> We have a machine with user.country=de where jstat prints ',' instead of '.' in
> numbers. Explicitly
> start with user.country=en as already done for user.language=en.
>
> I also refactored the common flags to a variable in utils.sh ... so there won't
> be the need
> to edit all these files once more :)
>
> Best regards,
> Goetz
>
> (Sorry for the second mail, first missed the bug text ...)
More information about the serviceability-dev
mailing list