RFR(XS): 8205108: [testbug] Fix pattern matching in jstatd tests.

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Tue Jun 19 10:46:10 UTC 2018


Hi Thomas, 

thanks for your review!

I think the upper example output stems from some older 
jstatd. Probably the output got two new values added.
I don't feel like making up values, so I'd rather remove the 
old output. Is that fine with you?

Best regards,
  Goetz.

> -----Original Message-----
> From: Thomas Stüfe [mailto:thomas.stuefe at gmail.com]
> Sent: Samstag, 16. Juni 2018 19:26
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> Cc: serviceability-dev (serviceability-dev at openjdk.java.net) <serviceability-
> dev at openjdk.java.net>
> Subject: Re: RFR(XS): 8205108: [testbug] Fix pattern matching in jstatd tests.
> 
> Hi Goetz,
> 
> Looks reasonable. Could you please fix up the example output above the
> alternative you added, it misses the columns "CGC" and "CGCT".
> 
> Thanks, Thomas
> 
> On Sat, Jun 16, 2018 at 9:24 AM, Lindenmaier, Goetz
> <goetz.lindenmaier at sap.com> wrote:
> > Hi,
> >
> > Please review this test fix:
> > http://cr.openjdk.java.net/~goetz/wr18/8205108-fixJstatDTestPattern/01/
> >
> > The values for 'M' must be parsed as PERCENTAGE_OR_DASH.
> > The parsing of numbers should not depend on the locale.
> > I changed the parsing to use java.text.NumberFormat
> >
> > Best regards,
> >   Goetz.
> >


More information about the serviceability-dev mailing list