RFR : JDK-8204661 - Show error 'Port already in use' in HashedPasswordFileTest.java

[Harsha Wardhana B]

Hi David,

Thanks for the review. I have ran the tests in Mach5 10 times on each 
platform and I haven't seen any failure. I will update the bug with the 
chosen approach. Would you require a separate webrev for copyright update?

Regards
Harsha

On Wednesday 20 June 2018 05:12 PM, David Holmes wrote:
> Hi Harsha,
>
> On 20/06/2018 6:14 PM, Harsha Wardhana B wrote:
>> Hi,
>>
>> Please find the fix below for the bug
>>
>> JDK-8204661 : Show error 'Port already in use' in 
>> HashedPasswordFileTest.java
>>
>> having webrev at,
>>
>> http://cr.openjdk.java.net/~hb/8204661/webrev.00/
>>
>> The problem root-cause is discussed in the comments section of the bug.
>>
>> The fix above lets the default agent pick a free port by passing 
>> 'port=0' value and then reads the JMX Connector URL from Perf Counters.
>
> Can you update the bug report with the actual solution chosen. I find 
> it interesting that I can't see any other test using this technique. 
> If port=0 means the port bind can't fail then this may be the 
> technique all tests should be using for reliability - though it's a 
> pity there's no public API supporting reading back the URL.
>
> Have you run the test through mach5 repeatedly to check all (Posix) 
> platforms and a range of systems? You can use "--test-repeat 10" for 
> example to run it 10 times on each platform.
>
>> Please review the fix above and provide comments.
>
> The copyright needs to changed to the two year format:
>
> * Copyright (c) 2017, Oracle and/or its affiliates. All rights reserved.
>
> becomes
>
> * Copyright (c) 2017, 2018, Oracle and/or its affiliates. All rights 
> reserved.
>
> Otherwise this seems okay.
>
> Thanks,
> David
>
>> Thanks
>> Harsha
>>
>>