[12] RFR (S) 8205534: Remove SymbolTable dependency from serviceability agent

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Tue Jun 26 19:33:10 UTC 2018


Thank you for reviewing, Gerard!
Coleen

On 6/26/18 3:31 PM, Gerard Ziemski wrote:
> hi Coleen,
>
> Looks good, just need to update the copyright years here (don’t need to see the webrev):
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/classfile/ClassLoaderDataGraph.java
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Field.java
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Method.java
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Symbol.java
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/ObjectReader.java
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/soql/JSJavaFactoryImpl.java
> test/hotspot/jtreg/serviceability/sa/ClhsdbPrintStatics.java
> test/hotspot/jtreg/serviceability/sa/ClhsdbSource.java
>
> Thank you for doing this!
>
>
> cheers
>
>> On Jun 22, 2018, at 4:40 PM, coleen.phillimore at oracle.com wrote:
>>
>> Summary: Modify SA code to not use SymbolTable and remove it.
>>
>> This is to support the concurrent hashtable for SymbolTable.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8205534.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8205534
>>
>> Tested with hs-tier1-5.
>>
>> Thanks,
>> Coleen



More information about the serviceability-dev mailing list