RFR : JDK-8192953 - sun/management/jmxremote/bootstrap/*.sh tests fail with error : revokeall.exe: Permission denied

[Harsha Wardhana B]

Apart from removing revokeall.exe, all the shell scripts must be 
converted to Java programs.

I have raised JDK-8205972 to track that effort.

Harsha

On Wednesday 27 June 2018 10:38 PM, mandy chung wrote:
> What refactoring are you thinking about about?
>
> It should be straight-forward to write an utility in java to replace 
> revokeall.exe.  As it has been a long-standing testing reliability 
> issue and this is a test-only bug, you have time to fix in 11.
>
> Also, your fix does not work if "open" directory does not exist.
>
> Mandy
>
> On 6/27/18 9:28 AM, Harsha Wardhana B wrote:
>> Since the tests are failing in every CI run, we have the option to 
>> push this fix or quarantine the tests. Refactoring the tests takes 
>> more than a week of effort and tests will have to be quarantined till 
>> then. I guess pushing this fix is the right thing to do now.
>>
>> Harsha
>>
>> On Wednesday 27 June 2018 09:52 PM, mandy chung wrote:
>>> I think the right thing to do is to bite the bullet and fix the test 
>>> properly.
>>>
>>> In addition, this fix does not seem to work if there is no "open" 
>>> directory.
>>>
>>> Mandy
>>>
>>> On 6/27/18 9:03 AM, Harsha Wardhana B wrote:
>>>> That will be done subsequently and tracked under a different bug. 
>>>> Don't you think pushing this fix is better than quarantining the 
>>>> tests?
>>>>
>>>> Harsha
>>>>
>>>> On Wednesday 27 June 2018 08:50 PM, mandy chung wrote:
>>>>> I would suggest to take the time and replace it with java.nio.file 
>>>>> API and remove revokeall.exe sooner rather than later.
>>>>>
>>>>> Mandy
>>>>>
>>>>> On 6/26/18 7:09 AM, Harsha Wardhana B wrote:
>>>>>> Hi All,
>>>>>>
>>>>>> Please find the fix for the bug,
>>>>>>
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8192953
>>>>>>
>>>>>> having webrev at,
>>>>>>
>>>>>> http://cr.openjdk.java.net/~hb/8192953/webrev.00/
>>>>>>
>>>>>> The fix grants execute permission for revokeall.exe. The paths in 
>>>>>> the shell sciprt had to be converted to cygwin paths 
>>>>>> (/cygwin/c/... ) from windows path (C:/...). Using windows path 
>>>>>> was causing strange behavior in cygwin.
>>>>>>
>>>>>> revokeall.exe should be removed and the above tests need to be 
>>>>>> refactored to use java.nio.Acl* APIs. That plan is in the near 
>>>>>> future, and the current fix needs to go in to stop consistent 
>>>>>> failures in Mach5.
>>>>>>
>>>>>> Please review the above patch and provide feedback if any.
>>>>>>
>>>>>> Thanks
>>>>>> Harsha
>>>>>>
>>>>
>>