PING: RFR: JDK-8153333: [REDO] STW phases at Concurrent GC should count in PerfCounter

[Yasumasa Suenaga]

Hi Thomas,

>    - one really minor issue I think: in the description in
> JstatGcCauseResults.java, the descriptions of the new concurrent
> collections, between "GCT" and "Total Garbage collection time." there
> should probably be one space less to align with the "main" gc phase
> times.
> 
>    - in gcCapacityOutput1.awk, gcNewCapacityOutput1.awk, there are some
> additional newlines (line 10/11).

Thanks!
I will fix them.


Yasumasa


On 2018/03/09 17:41, Thomas Schatzl wrote:
> Hi Yasumasa,
> 
> On Wed, 2018-03-07 at 21:18 +0900, Yasumasa Suenaga wrote:
>> PING: Could you review it?
>>
>>     http://cr.openjdk.java.net/~ysuenaga/JDK-8153333/webrev.08/
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8153333
>> CSR: https://bugs.openjdk.java.net/browse/JDK-8196862
>>
>> This change has passed Mach5 on submit repo.
>> Also it has passed hotspot/jtreg/:hotspot_serviceability and
>> jdk/:jdk_tools jtreg tests.
>>
>> We need one more reviewer.
> 
>    - one really minor issue I think: in the description in
> JstatGcCauseResults.java, the descriptions of the new concurrent
> collections, between "GCT" and "Total Garbage collection time." there
> should probably be one space less to align with the "main" gc phase
> times.
> 
>    - in gcCapacityOutput1.awk, gcNewCapacityOutput1.awk, there are some
> additional newlines (line 10/11).
> 
> No need for re-review from me, and for the change in
> JstatGcCauseResults.java I am not completely sure my suggestion is
> good.
> 
> Stefan Johansson already mentioned he will sponsor.
> 
> Thanks,
>    Thomas
>