RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr
David Holmes
david.holmes at oracle.com
Mon Mar 12 02:52:53 UTC 2018
Hi Chris,
On 10/03/2018 6:46 AM, Chris Plummer wrote:
> Hello,
>
> Please help review the following:
>
> https://bugs.openjdk.java.net/browse/JDK-8198655
> http://cr.openjdk.java.net/~cjplummer/8198655/webrev.00/webrev/
>
> In the end there were two issues. The first was that the
> pb.redirectError() call was redirecting the LingeredApp's stderr to the
> console, which we don't want. The second was that nothing was capturing
> the LingeredApp's output and sending it to the driver app's output (jtr
> file). These changes make all the LingeredApp's output end up in the jtr
> file.
It isn't clear to me how the interleaving of the two streams by the two
threads is handled in the copy routine. Are we guaranteed to get
complete lines of output from each stream before writing to System.out?
Thanks,
David
-----
> Tested by running all tests that use LingeredApp.
>
> thanks,
>
> Chris
More information about the serviceability-dev
mailing list