RFR : JDK-8196744 : JMX: Not enough JDP packets received before timeout

David Holmes david.holmes at oracle.com
Mon Mar 19 20:43:56 UTC 2018


Hi Harsha,

Given the negative nature of the test this approach seems quite reasonable.

Thanks,
David

> Harsha Wardhana B <harsha.wardhana.b at oracle.com> 
> 
> Ping! Can I have one more review for the below fix?
> 
> Thanks
> 
> Harsha
> 
> On Monday 26 February 2018 10:42 AM, Harsha Wardhana B wrote:
> 
>> Hello All,
> 
>>
> 
>> Requesting for review from one more reviewer.
> 
>>
> 
>> Thanks
> 
>> Harsha
> 
>>
> 
>> On Wednesday 21 February 2018 10:01 AM, Chris Plummer wrote:
> 
>>> Hi Harsha,
> 
>>>
> 
>>> Not a review, but just a request that you add the explanation of the 
> 
>>> problem to the CR so we have a record of it. Also, the copyright 
> 
>>> needs to be updated.
> 
>>>
> 
>>> thanks,
> 
>>>
> 
>>> Chris
> 
>>>
> 
>>> On 2/20/18 3:30 AM, Harsha Wardhana B wrote:
> 
>>>> Hi All,
> 
>>>>
> 
>>>> Please find the fix below for the Jdp test-case.
> 
>>>>
> 
>>>> issue: https://bugs.openjdk.java.net/browse/JDK-8196028
> 
>>>> webrev : http://cr.openjdk.java.net/~hb/8196028/webrev.00/
> 
>>>>
> 
>>>> Fix details : The test was receiving JDP packets from other VM and 
> 
>>>> hence the multi-cast socket was not timing-out. The default timeout 
> 
>>>> handler was causing test to fail. Added a shutdown method that 
> 
>>>> passes the test in case of timeout.
> 
>>>>
> 
>>>> Thanks
> 
>>>> Harsha
> 
>>>
> 
>>>
> 
>>
> 


More information about the serviceability-dev mailing list