RFR: JDK-8198393: Instrumentation.retransformClasses() throws NullPointerException when handling a zero-length array

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Mon Mar 26 21:33:34 UTC 2018


Forgot to tell that the copyright comment in the 
InstrumentationImpl.java needs an update.

Thanks,
Serguei


On 3/26/18 14:31, serguei.spitsyn at oracle.com wrote:
> Hi Alex,
>
> It looks good to me.
>
> A couple of questions:
>
>  - How does the test fail with the unfixed code?
>
>  - It seems, the following imports in the test are not needed:
>
>   34 import java.io.IOException;
>   . . .
>   43 import java.util.Arrays;
>   . . .
>   45 import jdk.test.lib.Utils;
>   46 import jdk.test.lib.process.ExitCode;
>   47 import jdk.test.lib.process.OutputAnalyzer;
>
> Thanks,
> Serguei
>
>
> On 3/22/18 16:18, Alex Menkov wrote:
>> Hi all,
>>
>> Please take a look at a simple fix for
>> https://bugs.openjdk.java.net/browse/JDK-8198393
>> webrev: 
>> http://cr.openjdk.java.net/~amenkov/retransformClassesZeroLength/webrev/
>>
>> --alex
>



More information about the serviceability-dev mailing list