RFR 8203802: Jvmti test fails to build with VS2017

Erik Joelsson erik.joelsson at oracle.com
Tue May 29 21:37:09 UTC 2018


Looks good to me.

/Erik


On 2018-05-29 14:35, Daniil Titov wrote:
> Hi Serguei,
>
> Thank you, for review.
>
> I will need one more reviewer to push this changes.
>
> Best regards,
> Daniil
>
>
> On 5/29/18, 12:01 PM, "serguei.spitsyn at oracle.com" <serguei.spitsyn at oracle.com> wrote:
>
>      Hi Daniil,
>      
>      It looks good.
>      
>      Thanks,
>      Serguei
>      
>      
>      On 5/26/18 11:57, Daniil Titov wrote:
>      > Please review the changes that fix a build failure for Jvmti tests.
>      >
>      > The fix replaces printf "%ld" format with JLONG_FORMAT macro defined in the same way as it is defined in the hotspot (src/hotspot//share/utilities/globalDefinitions.hpp and src/hotspot//share/utilities/globalDefinitions_gcc.hpp)
>      >
>      > Bug: https://bugs.openjdk.java.net/browse/JDK-8203802
>      > Webrev: http://cr.openjdk.java.net/~dtitov/8203802/webrev.01
>      >
>      >
>      > Mach5 builds and hs-tier1-3, jdk-tier1-3 tests were completed successfully.
>      >
>      > Best regards,
>      > Daniil
>      >
>      >
>      
>      
>
>



More information about the serviceability-dev mailing list