RFR: (S): JDK-8213323: sa/TestJmapCoreMetaspace.java and sa/TestJmapCore.java fail with ZGC

[JC Beyler]

Hi Jini,

The webrev looks good to me as well except for a few questions/comments:

I have a generic question that is related to the webrev:
  - Are there plans at some point for Jmap to support ZGC heaps in the
future ? Or is this infeasible?
        I ask because if a lot of tests are disabled for ZGC for a limited
amount of time (in order to provide time for future support) there should
be a means to scrub the tests at a later date to see which are now
supported, no?

  - In
http://cr.openjdk.java.net/~jgeorge/8213323/webrev.00/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java.html
:

 397         if (vm.getUniverse().heap() instanceof ZCollectedHeap) {
 398             System.err.println("WARNING: Operation not supported for
ZGC.");
 399             return;
 400         };

     - 1 nit is the ';'  after the closing '}'
     - Should the code throw a RuntimeException instead? Just printing an
error seems "weak" for me when this really won't work. Of course, that
means tracking the callers now of write and probably adding exception
handling there and I'm not sure that is something that is warranted here
but thought I would ask :)

Thanks!
Jc



Thanks,
Jc

On Fri, Nov 9, 2018 at 1:47 AM gary.adams at oracle.com <gary.adams at oracle.com>
wrote:

> Looks OK to me.
>
> On 11/9/18 1:40 AM, Jini George wrote:
> > Hello!
> >
> > Requesting reviews for a small change for disabling the testing of
> > TestJmapCoreMetaspace.java and TestJmapCore.java with ZGC. The change
> > also includes skipping of creating the heapdump file with jmap if the
> > GC being used is ZGC.
> >
> > Webrev: http://cr.openjdk.java.net/~jgeorge/8213323/webrev.00/
> > Bug ID: https://bugs.openjdk.java.net/browse/JDK-8213323
> >
> > Thanks,
> > Jini.
>
>
>

-- 

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20181109/6eefa41c/attachment-0001.html>