RFR 8205654: serviceability/dcmd/framework/HelpTest.java timed out

[David Holmes]

Hi Daniil,

I took a quick look at this one ... two minor comments

The static class names could just be "Process" as they will acquire the 
enclosing class name as part of their own name anyway. As it is this 
gets repeated eg:

HelpTest$HelpTestProcess
InvalidCommandTest$InvalidCommandTestProcess

TestJavaProcess.java:

39     public static void main(String argv[]) {

Nit: Should be "String[] argv" in Java style

Thanks,
David

On 10/11/2018 3:18 PM, Daniil Titov wrote:
> Please review the change that fixes serviceability/dcmd/framework/* tests from a time out. The fix for JDK-8166642 made serviceability/dcmd/framework/* tests non-concurrent to ensure that they don't interact with each other and there are no multiple tests running simultaneously since all they do share the common main class name com.sun.javatest.regtest.agent.MainWrapper. However, it looks like the  tests from other directories still might run in parallel with these tests and they also have com.sun.javatest.regtest.agent.MainWrapper as a main class.
> 
> The fix  ensures that each serviceability/dcmd/framework/* test uses a Java process with a unique main class name when connecting to this process with jcmd and the main class name.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8205654
> Webrev: http://cr.openjdk.java.net/~dtitov/8205654/webrev.001/
> 
> Best regards,
> Daniil
> 
>