RFR(XXS): 8214105: Invalid bit tests in jtreg

Simon Tooke stooke at redhat.com
Tue Nov 20 14:34:46 UTC 2018


While compiling the JDK with GCC 8.1, I discovered an invalid bit test
in
test/hotspot/jtreg/serviceability/jvmti/StartPhase/AllowedFunctions/libAllowedFunctions.c.  


    (status & JVMTI_CLASS_STATUS_INITIALIZED) == 1

Which only has a chance of being true if JVMTI_CLASS_STATUS_INITIALIZED
has a value 1 (its actual value is 4, but that's beside the point).
My proposed fix is to test for != 0 instead.  I chose this instead of
testing for equality to JVMTI_CLASS_STATUS_INITIALIZED purely for
cosmetic reasons.

Bug: https://bugs.openjdk.java.net/browse/JDK-8214105
webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/stooke/JDK-8214105/01/webrev/

Please let me know what you think.

Thanks,
-Simon




More information about the serviceability-dev mailing list