[8u] RFR: 8210836: Build fails with warn_unused_result in openjdk/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c

Severin Gehwolf sgehwolf at redhat.com
Wed Nov 21 10:20:37 UTC 2018


On Wed, 2018-11-21 at 06:47 +0000, Andrew Hughes wrote:
> On Mon, 19 Nov 2018 at 15:39, Severin Gehwolf <sgehwolf at redhat.com> wrote:
> 
> snip...
> 
> > 
> > Two reasons: (1) JDK-8140482 isn't a small change. (2) The patch
> > doesn't apply cleanly[1] from JDK 9 so would be some work to get the
> > pre-requisite in.
> > 
> > It appears the code is already out of sync and the risk would be higher
> > if we backported all of JDK-8140482 for a relatively small change of
> > JDK-8210836.
> > 
> > The aim was to keep the backport as minimal as possible.
> > 
> 
> Not too bad. I've proposed it:
> 
> https://mail.openjdk.java.net/pipermail/hotspot-dev/2018-November/035349.html

Nice! The JDK 12 change from 8210836 applies as-is (post-path-
shuffeling) with this dependency in place.

Thanks,
Severin



More information about the serviceability-dev mailing list