RFR (L) 8214149: Move out assignments when not using NSK*VERIFY macros

[JC Beyler]

Thanks both,

Tested on dev machine & submit repo and pushed,
Jc

On Tue, Nov 20, 2018 at 8:27 PM serguei.spitsyn at oracle.com <
serguei.spitsyn at oracle.com> wrote:

> Hi Jc,
>
> ++(LG+TFTC)
>
> Thanks,
> Serguei
>
>
> On 11/20/18 19:44, Chris Plummer wrote:
>
> Hi JC,
>
> Looks great. Thanks for the cleanup.
>
> Chris
>
>
> On 11/20/18 4:27 PM, JC Beyler wrote:
>
> Hi all,
>
> As we work out the details for removing the NSK*VERIFY macros and the
> assignments in ifs in those cases, here is a webrev for assignments without
> the macros.
>
> Webrev: http://cr.openjdk.java.net/~jcbeyler/8210687/webrev.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8214149
>
> I've launched testing for the whole vmTestbase test suite since this
> touched a few shared files. I don't expect any surprises :-).
>
> Note that, technically, we could also do the alternative of adding the
> macros for each if statement instead :). I'd rather just move the
> assignments out and then, as we agree about how to roll out a better
> tracing/verification mechanism across the vmTestbase code base, we will
> automatically encompass these and thus add coverage at that moment.
>
> Thanks,
> Jc
>
>
>
>

-- 

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20181121/e0969ff8/attachment.html>