RFR (L) 8214417: Add space after/before {} in vmTestbase/nsk/jvmti/[A-I] tests
Alex Menkov
alexey.menkov at oracle.com
Wed Nov 28 23:43:55 UTC 2018
Hi Jc,
In the JDK-8212771 review thread cleanup for "{}" was requested for
statements like
test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/MethodBind/JvmtiTest/JvmtiTest.cpp,
+#define JVMTI_ERROR_CHECK(str,res) if (res != JVMTI_ERROR_NONE) {
printf(str); printf("%d\n",res); return res;}
+#define JVMTI_ERROR_CHECK_EXPECTED_ERROR(str,res,err) if (res != err) {
printf(str); printf("unexpected error %d\n",res); return res;}
I.e. something like ";}" -> "; }"
I don't think changes like
-static jvmtiEvent testEvents[] = {JVMTI_EVENT_THREAD_START,
JVMTI_EVENT_THREAD_END};
+static jvmtiEvent testEvents[] = { JVMTI_EVENT_THREAD_START,
JVMTI_EVENT_THREAD_END };
are required.
--alex
On 11/28/2018 11:20, JC Beyler wrote:
> Hi all,
>
> When working on a previous clean-up (JDK-8212771), I was asked to
> clean-up also spaces around {}.
>
> Here is the first batch out of 2 to fix these cases. Let me know what
> you think.
>
> Webrev: http://cr.openjdk.java.net/~jcbeyler/8214417/webrev.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8214417
>
> Thanks for your reviews :-),
> Jc
More information about the serviceability-dev
mailing list