RFR (L) 8214502: Add space after/before {} in remaining vmTestbase tests
JC Beyler
jcbeyler at google.com
Fri Nov 30 05:12:37 UTC 2018
Thanks David :)
For reference:
jdk12-spaces/test/hotspot/jtreg/vmTestbase$ grep "{[^ }]" `find . -name
"*cpp"`
./nsk/stress/jni/gclocker/libgcl001.cpp:{\
jdk12-spaces/test/hotspot/jtreg/vmTestbase$ grep "[^ {]}" `find . -name
"*cpp"`
./nsk/share/jvmti/jvmti_tools.cpp: //}
Have a great evening,
Jc
On Thu, Nov 29, 2018 at 8:21 PM David Holmes <david.holmes at oracle.com>
wrote:
> Looks good!
>
> I only examined what you changed, I did not try to see if you had missed
> anything :)
>
> Thanks,
> David
>
> On 30/11/2018 2:10 pm, JC Beyler wrote:
> > Hi all,
> >
> > Could I get a review for adding a space around the {} for the
> > vmTestbase. This webrev handles all remaining cases for vmTestbase :-)
> >
> > Here is the webrev and bug:
> > Webrev: http://cr.openjdk.java.net/~jcbeyler/8214502/webrev.00/
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8214502
> >
> > Thanks for your help!
> > Jc
>
--
Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20181129/696253d2/attachment.html>
More information about the serviceability-dev
mailing list