RFR (M) 8211261: Remove the NSK_CPP_STUB macros from vmTestbase for jvmti/[A-G]*
Alex Menkov
alexey.menkov at oracle.com
Mon Oct 1 17:16:28 UTC 2018
LGTM
--alex
On 09/28/2018 19:44, JC Beyler wrote:
> Hi Alex,
>
> Thanks for the review and nice catch. I updated my scripts and now fix
> that corner case. Here is the incremental webrev that fixes a few more
> white space issues:
> Webrev: http://cr.openjdk.java.net/~jcbeyler/8211261/webrev.00_01
> <http://cr.openjdk.java.net/%7Ejcbeyler/8211261/webrev.00_01>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8211261
>
> The full webrev is here:
> Webrev: http://cr.openjdk.java.net/~jcbeyler/8211261/webrev.01
> <http://cr.openjdk.java.net/%7Ejcbeyler/8211261/webrev.01>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8211261
>
> Let me know what you think,
> Jc
>
> On Fri, Sep 28, 2018 at 10:20 AM Alex Menkov <alexey.menkov at oracle.com
> <mailto:alexey.menkov at oracle.com>> wrote:
>
> Hi Jc,
>
> Overall looks good.
> Could you please update
> ForceEarlyReturn/ForceEarlyReturn001/ForceEarlyReturn001.cpp manually -
> converted calls contain a lot of unnecessary spaces.
>
> --alex
>
> On 09/27/2018 22:15, JC Beyler wrote:
> > Hi all,
> >
> > I continued the NSK_CPP_STUB removal with this webrev:
> >
> > Webrev: http://cr.openjdk.java.net/~jcbeyler/8211261/webrev.00/
> <http://cr.openjdk.java.net/%7Ejcbeyler/8211261/webrev.00/>
> > <http://cr.openjdk.java.net/%7Ejcbeyler/8211261/webrev.00/>
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8211261
> >
> > This does the another set of 50 files of the jvmti subfolder, it
> is done
> > automatically by the scripts I put in the bug comments.
> >
> > This passes the tests changed on my dev machine.
> >
> > Let me know what you think,
> > Jc
>
>
>
> --
>
> Thanks,
> Jc
More information about the serviceability-dev
mailing list