RFR: JDK-8211324: Link to java.lang.ThreadGroup in JDWP spec is broken

Gary Adams gary.adams at oracle.com
Tue Oct 9 11:39:25 UTC 2018


Patch attached.

I'll need a sponsor for the push.

On 10/8/18, 3:58 PM, serguei.spitsyn at oracle.com wrote:
> Hi Gary,
>
> +1
>
> Thanks,
> Serguei
>
> On 10/8/18 11:30, Chris Hegarty wrote:
>> The updated link looks ok to me.
>>
>> -Chris
>>
>>> On 8 Oct 2018, at 19:15, Gary Adams <gary.adams at oracle.com> wrote:
>>>
>>> Alan suggested in the bug report for the broken link from the 
>>> jdwp-protocol
>>> spec to the java/lang/ThreadGroup documentation to simply remove the
>>> href link. Another possibility is to simply update the link to 
>>> include the java.base
>>> subdirectory.
>>>
>>> I don't think the doc structure changes very often so either solution
>>> seems fine to me.
>>>
>>> diff --git a/make/data/jdwp/jdwp.spec b/make/data/jdwp/jdwp.spec
>>> --- a/make/data/jdwp/jdwp.spec
>>> +++ b/make/data/jdwp/jdwp.spec
>>> @@ -2185,7 +2185,7 @@
>>>          "in this thread group. Threads and thread groups in child "
>>>          "thread groups are not included. "
>>>          "A thread is alive if it has been started and has not yet 
>>> been stopped. "
>>> -        "See <a 
>>> href=../../../api/java/lang/ThreadGroup.html>java.lang.ThreadGroup </a>
>>> +        "See <a 
>>> href=../../api/java.base/java/lang/ThreadGroup.html>java.lang.ThreadGroup 
>>> </a>
>>>          "for information about active ThreadGroups.
>>>          (Out
>>>              (threadGroupObject group "The thread group object ID. ")
>

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 8211324.patch
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20181009/f87cc1fb/8211324.patch>


More information about the serviceability-dev mailing list