RFR (S) 8211432: [REDO] Handle JNIGlobalRefLocker.cpp

Hohensee, Paul hohensee at amazon.com
Tue Oct 9 22:54:25 UTC 2018

Is the pointer itself constant? I.e., “const char* const base_msg”?


From: serviceability-dev <serviceability-dev-bounces at openjdk.java.net> on behalf of JC Beyler <jcbeyler at google.com>
Date: Tuesday, October 9, 2018 at 5:23 PM
To: "serviceability-dev at openjdk.java.net" <serviceability-dev at openjdk.java.net>
Subject: RFR (S) 8211432: [REDO] Handle JNIGlobalRefLocker.cpp

Hi all,

When I pushed the fix for JDK-8210842<https://bugs.openjdk.java.net/browse/JDK-8210842>, I failed to realize there was seemingly an issue when using std::string. This provoked a failure for Windows and Solaris builds described in the bug for this fix.

Therefore I offer a solution using const char* instead to not have any issues:

Webrev: http://cr.openjdk.java.net/~jcbeyler/8211432/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8211432

The incremental between the previous fix and this one is here so that it helps see the differences:

Finally, this has passed the submit-repo smoke-screen.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20181009/3d17111b/attachment.html>

More information about the serviceability-dev mailing list