RFR 8211736: jdb doesn't print prompt when breakpoint is hit and suspend policy is STOP_EVENT_THREAD
Daniil Titov
daniil.x.titov at oracle.com
Fri Oct 12 03:02:26 UTC 2018
Thank you, JC!
Please review an updated version of the patch that fixes newly added test for Windows platform (now it uses system dependent line separator string).
Webrev: http://cr.openjdk.java.net/~dtitov/8211736/webrev.02/
Issue: https://bugs.openjdk.java.net/browse/JDK-8211736
Best regards,
--Daniil
From: JC Beyler <jcbeyler at google.com>
Date: Thursday, October 11, 2018 at 7:17 PM
To: <daniil.x.titov at oracle.com>
Cc: <serviceability-dev at openjdk.java.net>
Subject: Re: RFR 8211736: jdb doesn't print prompt when breakpoint is hit and suspend policy is STOP_EVENT_THREAD
Hi Daniil,
Looks good to me. I saw a really small nit:
http://cr.openjdk.java.net/~dtitov/8211736/webrev.01/test/jdk/com/sun/jdi/JdbStopThreadTest.java.html
70 jdb.command(JdbCommand.stopThreadAt( DEBUGGEE_CLASS ,bpLine));
There is a space after the '('.
No need to send a new webrev for that evidently :),
Jc
On Thu, Oct 11, 2018 at 5:07 PM Daniil Titov <daniil.x.titov at oracle.com> wrote:
Please review the change that fixes the issue with missing prompt in jdb when a breakpoint is hit and the suspend policy is set to stop the thread only.
Webrev: http://cr.openjdk.java.net/~dtitov/8211736/webrev.01
Issue: https://bugs.openjdk.java.net/browse/JDK-8211736
Thanks!
--Daniil
--
Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20181011/a04ebf7d/attachment-0001.html>
More information about the serviceability-dev
mailing list