Restoring nsk/jvmti/scenarios/hotswap tests from ProblemList.txt

[Alex Menkov]

+1

--alex

On 10/17/2018 11:10, Chris Plummer wrote:
> The changes look fine.
> 
> thanks,
> 
> Chris
> 
> On 10/17/18 4:45 AM, Gary Adams wrote:
>> While investigating other issues with hotswap tests I noticed
>> 2 tests on the Problemlist that I think can be restored.
>>
>> I have not been able to reproduce the failure with hs102t002
>> It is marked in the ProblemList as related to JDK-8203350,
>> but that bug is about hs201t002. It is also marked as related
>> to JDK-8204506, which is concerned with test hs102t002, but
>> is specific to a graal failure and is already recorded in
>> ProblemList-graal.txt
>>
>>   https://bugs.openjdk.java.net/browse/JDK-8203350
>>   https://bugs.openjdk.java.net/browse/JDK-8204506
>>
>> I did run into some intermittent failures with hs204t001 and the
>> utility class ExecDriver. It appears that it took advantage of other 
>> tests
>> building the class file. A simple directive to build ExecDirver will 
>> bring it
>> in line with the other hotswap tests.
>>
>> diff --git a/test/hotspot/jtreg/ProblemList.txt 
>> b/test/hotspot/jtreg/ProblemList.txt
>> --- a/test/hotspot/jtreg/ProblemList.txt
>> +++ b/test/hotspot/jtreg/ProblemList.txt
>> @@ -184,8 +184,6 @@
>>  vmTestbase/nsk/jvmti/ResourceExhausted/resexhausted004/TestDescription.java 
>> 7013634,6606767 generic-all
>>  vmTestbase/nsk/jvmti/ThreadStart/threadstart001/TestDescription.java 
>> 8016181 generic-all
>>  vmTestbase/nsk/jvmti/scenarios/extension/EX03/ex03t001/TestDescription.java 
>> 8173658 generic-all
>> -vmTestbase/nsk/jvmti/scenarios/hotswap/HS102/hs102t002/TestDescription.java 
>> 8204506,8203350 generic-all
>> -vmTestbase/nsk/jvmti/scenarios/hotswap/HS204/hs204t001/hs204t001.java 
>> 6813266 generic-all
>>  vmTestbase/nsk/jvmti/scenarios/sampling/SP06/sp06t003/TestDescription.java 
>> 8051349 generic-all
>>  vmTestbase/nsk/jvmti/AttachOnDemand/attach034/TestDescription.java 
>> 8042145 generic-all
>>  vmTestbase/nsk/jvmti/AttachOnDemand/attach045/TestDescription.java 
>> 8202971 generic-all
>>
>>
>> diff --git 
>> a/test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/hotswap/HS204/hs204t001/hs204t001.java 
>> b/test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/hotswap/HS204/hs204t001/hs204t001.java 
>>
>> --- 
>> a/test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/hotswap/HS204/hs204t001/hs204t001.java 
>>
>> +++ 
>> b/test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/hotswap/HS204/hs204t001/hs204t001.java 
>>
>> @@ -46,7 +46,8 @@
>>   * @library /vmTestbase
>>   *          /test/lib
>>   * @run driver jdk.test.lib.FileInstaller . .
>> - * @build nsk.jvmti.scenarios.hotswap.HS204.hs204t001.hs204t001
>> + * @build ExecDriver
>> + *      nsk.jvmti.scenarios.hotswap.HS204.hs204t001.hs204t001
>>   *
>>   * @comment compile newclassXX to bin/newclassXX
>>   * @run driver nsk.share.ExtraClassesBuilder
>>
> 
>