Re: КАК JDK-8212665: com/sun/jdi/DeferredStepTest.java: jj1 (line 57) - unexpected. lastLine=52, minLine=52, maxLine=55

[JC Beyler]

Hi Alex,

Looks good to me.

Two nits:
  - The loops you changed are using ii as the loop counter, any reason we
would not just put it to i?
 - The last comment change, the loop line right under has no spacings, we
could extend the webrev a tiny bit and add some spaces?

There is no need to resend a webrev for these, regardless if you do them or
not :)
Jc

On Thu, Oct 18, 2018 at 3:43 PM Alex Menkov <alexey.menkov at oracle.com>
wrote:

> Hi all,
>
> Please review small test fix for
> https://bugs.openjdk.java.net/browse/JDK-8212665
> webrev:
> http://cr.openjdk.java.net/~amenkov/deferredStep_endOfCycle/webrev/
>
> The test verifies that after "next" command debugger always stops in the
> position within loops. Each thread has maximum 40 stops (10 iterations,
> 4 lines each), but with 50 "next" command it's possible that one of the
> thread exits the loop.
> The fix increments loops to make 15 iterations, so each thread has more
> than 50 stops.
>
> --alex
>


-- 

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20181018/33fce9d0/attachment-0001.html>