RFR JDK-8212151: jdi/ExclusiveBind.java times out due to "bind failed: Address already in use" on Solaris-X64

[JC Beyler]

Hi Alex,

It looks really good to me now. The test and JdbTest are now easier to read
because we do not have the noise of the debuggee trying to attach.

A few nits:
  - Small nit really is the fact that the javadoc for Debuggee states two
usages and JdbTest does not use either :)
  - You put a few get methods in Debuggee that are seemingly not used
anywhere, we could add them later if need be and not have them now?

Thanks for this, I think it's really better in the long run to have this in
one centralized spot,
Jc

On Fri, Oct 19, 2018 at 3:56 PM Alex Menkov <alexey.menkov at oracle.com>
wrote:

> Hi Jc,
>
> Updated fix:
> http://cr.openjdk.java.net/~amenkov/exclusiveBind/webrev.01/
> Moved shared code to new Debuggee class.
>
> --alex
>
> On 10/19/2018 10:34, JC Beyler wrote:
> > Hi Alex,
> >
> > I remember seeing this same code so went looking for it and saw it in
> > JdbTest.java (you added it here it seems:
> > http://hg.openjdk.java.net/jdk/jdk/rev/083e731da31a).
> >
> > I have two few questions:
> >    - Does it make sense to put this code in a helper method?
> >    - The code you added in JdbTest.java does not do the adjusted time
> > for 30 it seems, is that normal?
> >
> > Thanks,
> > Jc
> >
> > On Fri, Oct 19, 2018 at 9:59 AM Alex Menkov <alexey.menkov at oracle.com
> > <mailto:alexey.menkov at oracle.com>> wrote:
> >
> >     Hi all,
> >
> >     jira: https://bugs.openjdk.java.net/browse/JDK-8212151
> >     webrev: http://cr.openjdk.java.net/~amenkov/exclusiveBind/webrev/
> >     <http://cr.openjdk.java.net/%7Eamenkov/exclusiveBind/webrev/>
> >
> >     The fix updates the test to allow debuggee to select available port
> >     instead of using error-prone "getFreePort" approach.
> >
> >     --alex
> >
> >
> >
> > --
> >
> > Thanks,
> > Jc
>


-- 

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20181020/1fae7088/attachment-0001.html>