RFR (M) 8212148: Remove remaining NSK_CPP_STUBs

[JC Beyler]

Hi all,

Igor actually finished cleaning up the closed tests, so I can go ahead and
push webrev.00.

Thanks all for your reviews and help :)
Jc

On Fri, Oct 19, 2018 at 9:05 PM Igor Ignatyev <igor.ignatyev at oracle.com>
wrote:

> LGTM
>
> -- Igor
>
> On Oct 19, 2018, at 7:40 PM, JC Beyler <jcbeyler at google.com> wrote:
>
> Hi all,
>
> I pushed the webrev into the submit repo and it failed to build due to
> internal tests that have references to the NSK_CPP_STUB. Here is the new
> webrev:
>
> Webrev: http://cr.openjdk.java.net/~jcbeyler/8212148/webrev.01/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8212148
>
> The only difference is I reverted the changes of the nsk_tools.h file
> which have the NSK_CPP_STUB. That file now contains the only references to
> the NSK_CPP_STUB macros until internally there are no references to them.
> Then we can remove the macros from the header file.
>
> Could I please get a new set of LGTM?
>
> (I've re-submitted this to the submit repo and am awaiting results)
>
> Thanks,
> Jc
>
> On Fri, Oct 19, 2018 at 12:02 PM Alex Menkov <alexey.menkov at oracle.com>
> wrote:
>
>> +1
>>
>> --alex
>>
>> On 10/19/2018 11:07, Hohensee, Paul wrote:
>> > Looks good.
>> >
>> > Paul
>> >
>> > *From: *serviceability-dev <serviceability-dev-bounces at openjdk.java.net>
>>
>> > on behalf of JC Beyler <jcbeyler at google.com>
>> > *Date: *Thursday, October 18, 2018 at 9:44 PM
>> > *To: *"serviceability-dev at openjdk.java.net"
>> > <serviceability-dev at openjdk.java.net>
>> > *Subject: *RFR (M) 8212148: Remove remaining NSK_CPP_STUBs
>> >
>> > Hi all,
>> >
>> > Here is the final webrev to remove the NSK_CPP_STUB! Please review the
>> > end of NSK_CPP_STUB.
>> >
>> > Webrev: http://cr.openjdk.java.net/~jcbeyler/8212148/webrev.00/
>> > <http://cr.openjdk.java.net/%7Ejcbeyler/8212148/webrev.00/>
>> >
>> > Bug: https://bugs.openjdk.java.net/browse/JDK-8212148
>> >
>> > I've tested the whole vmTestbase since this changed a few shared files.
>> > The whole suite passed on my dev machine.
>> >
>> > Let me know what you think,
>> >
>> > Jc
>> >
>>
>
>
> --
>
> Thanks,
> Jc
>
>
>

-- 

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20181022/0a9952b7/attachment.html>