RFR JDK-8212151: jdi/ExclusiveBind.java times out due to "bind failed: Address already in use" on Solaris-X64
serguei.spitsyn at oracle.com
serguei.spitsyn at oracle.com
Mon Oct 22 20:58:41 UTC 2018
Hi Alex,
LGTM.
Thanks,
Serguei
On 10/19/18 15:56, Alex Menkov wrote:
> Hi Jc,
>
> Updated fix:
> http://cr.openjdk.java.net/~amenkov/exclusiveBind/webrev.01/
> Moved shared code to new Debuggee class.
>
> --alex
>
> On 10/19/2018 10:34, JC Beyler wrote:
>> Hi Alex,
>>
>> I remember seeing this same code so went looking for it and saw it in
>> JdbTest.java (you added it here it seems:
>> http://hg.openjdk.java.net/jdk/jdk/rev/083e731da31a).
>>
>> I have two few questions:
>> - Does it make sense to put this code in a helper method?
>> - The code you added in JdbTest.java does not do the adjusted time
>> for 30 it seems, is that normal?
>>
>> Thanks,
>> Jc
>>
>> On Fri, Oct 19, 2018 at 9:59 AM Alex Menkov <alexey.menkov at oracle.com
>> <mailto:alexey.menkov at oracle.com>> wrote:
>>
>> Hi all,
>>
>> jira: https://bugs.openjdk.java.net/browse/JDK-8212151
>> webrev: http://cr.openjdk.java.net/~amenkov/exclusiveBind/webrev/
>> <http://cr.openjdk.java.net/%7Eamenkov/exclusiveBind/webrev/>
>>
>> The fix updates the test to allow debuggee to select available port
>> instead of using error-prone "getFreePort" approach.
>>
>> --alex
>>
>>
>>
>> --
>>
>> Thanks,
>> Jc
More information about the serviceability-dev
mailing list