RFR (M) 8210700: Clean up JNI_ENV_ARG and factorize the macros for vmTestbase/jvmti/unit tests

[Chris Plummer]

Hi JC,

Looks good. Just wanted to point out a couple of argument indentation 
choices you made that I like:

  280     ret = jvmti->Allocate(sizeof(jvmtiThreadInfo) * threads_count,
  281                           (unsigned char**)&thread_info);

  304     ret = jvmti->GetThreadListStackTraces(
  305         threads_count, thread_list, MAX_FRAMES_CNT, &stack_buf2);

I would have done these the same way, and is what I was trying to get 
across as my preferred way of handling multi-line argument listsbased on 
what column the first argument ends up in.

thanks,

Chris

On 9/13/18 1:26 PM, JC Beyler wrote:
> Hi all,
>
> We have arrived to the last webrev for removing the JNI_ENV macros 
> from the vmTestbase:
>
> Webrev: http://cr.openjdk.java.net/~jcbeyler/8210700/webrev.00/ 
> <http://cr.openjdk.java.net/%7Ejcbeyler/8210700/webrev.00/>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8210700
>
> Thanks again for the reviews,
> Jc