RFR JDK-8210725: com/sun/jdi/RedefineClearBreakpoint.java fails with waitForPrompt timed out after 60 seconds

[Gary Adams]

Is the log decoration typical?

98             jdb.log("=======================================");

Is the Utils.adjustTimeout() applied consistently?
e.g. is the timeout passed to waitFor() already adjusted?

If you are promoting log() to be publicly visible, then it
should be used for the other cases of println() in Jdb and JdbTest.

On 9/17/18, 1:58 PM, JC Beyler wrote:
> Hi Alex,
>
> Looks good to me,
> Jc
>
> On Mon, Sep 17, 2018 at 10:49 AM Alex Menkov <alexey.menkov at oracle.com 
> <mailto:alexey.menkov at oracle.com>> wrote:
>
>     Hi all,
>
>     please review small fix:
>     http://cr.openjdk.java.net/~amenkov/sh2java/timeout/webrev.01/
>     <http://cr.openjdk.java.net/%7Eamenkov/sh2java/timeout/webrev.01/>
>
>     It fixes
>     https://bugs.openjdk.java.net/browse/JDK-8210725
>     - accordingly the logs of the failing tests, they work as
>     expected, but
>     sometimes (busy environment?) there is no reply from jdb for 60
>     seconds,
>     so tests throw exception.
>     The timeout can be removed at all (so timeouts would be handled by
>     general jtreg timeout mechanism), but prefer keep smaller timeout for
>     jdb reply, but apply timefactor to the value.
>
>     Also the change fixes
>     https://bugs.openjdk.java.net/browse/JDK-8210748
>     - in the case of error additional logging is done to indicate certain
>     point where the error occurs.
>
>     --alex
>
>
>
> -- 
>
> Thanks,
> Jc

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20180917/3a272e49/attachment.html>