RFR: JDK-8210836 : Build fails with warn_unused_result in openjdk/src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c

[JC Beyler]

Hi Jini,

I was looking at the man page and am curious: it says that the method
returns 0 if the end-of-file is reached, does that never happen in this
case?

(seems like -1 is the error code and another call to pread in the file just
checks for <= 0; which also is weird since 0 just means end of file).

Thanks,
Jc

On Tue, Sep 18, 2018 at 6:06 AM Thomas Stüfe <thomas.stuefe at gmail.com>
wrote:

> Looks good. Thanks for fixing.
>
> ..Thomas
>
> On Tue, Sep 18, 2018 at 1:52 PM, Jini George <jini.george at oracle.com>
> wrote:
> > Hi all,
> >
> > Please review the small change for fixing the build failure in
> > src/jdk.hotspot.agent/linux/native/libsaproc/ps_core.c with
> > -Werror=unused-result.
> >
> > https://bugs.openjdk.java.net/browse/JDK-8210836
> > Webrev: http://cr.openjdk.java.net/~jgeorge/8210836/webrev.00/
> >
> > A quick review would be appreciated.
> >
> > Thank you!
> > Jini.
>


-- 

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20180918/29a9b04e/attachment.html>