RFR(XS): JDK-8210987: Extra newlines on Windows when running nsk jdb tests
JC Beyler
jcbeyler at google.com
Fri Sep 21 21:19:07 UTC 2018
Hi Chris,
Looks good to me!
Thanks,
Jc
On Fri, Sep 21, 2018 at 1:47 PM Chris Plummer <chris.plummer at oracle.com>
wrote:
> Hi,
>
> Please review the following:
>
> https://bugs.openjdk.java.net/browse/JDK-8210987
> http://cr.openjdk.java.net/~cjplummer/8210987/webrev.00/
>
> Here's an example of some "before" output on windows:
>
> > Sending command: cont
> >
> > reply[0]: >
> > reply[1]:
> > Method entered: "thread=MyThread-1", java.util.Locale.getDefault(),
> line=910 bci=0
> > reply[2]:
> >
> > reply[3]:
> > MyThread-1[1]
>
> And the same output after the fix:
>
> > Sending command: cont
> > reply[0]: >
> > reply[1]: Method entered: "thread=MyThread-1",
> java.util.Locale.getDefault(), line=910 bci=0
> > reply[2]:
> > reply[3]: MyThread-1[1]
>
> And this also matches the output we've been seeing on the unix platforms.
>
> thanks,
>
> Chris
>
>
--
Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20180921/ca6b1a3b/attachment-0001.html>
More information about the serviceability-dev
mailing list