RFR(XS): JDK-8210987: Extra newlines on Windows when running nsk jdb tests

Chris Plummer chris.plummer at oracle.com
Fri Sep 21 22:09:14 UTC 2018


Thanks David and JC!

On 9/21/18 2:57 PM, David Holmes wrote:
> Looks fine.
>
> Thanks,
> David
>
> On 21/09/2018 4:46 PM, Chris Plummer wrote:
>> Hi,
>>
>> Please review the following:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8210987
>> http://cr.openjdk.java.net/~cjplummer/8210987/webrev.00/
>>
>> Here's an example of some "before" output on windows:
>>
>>> Sending command: cont
>>>
>>> reply[0]: >
>>> reply[1]:
>>> Method entered: "thread=MyThread-1", java.util.Locale.getDefault(), 
>>> line=910 bci=0
>>> reply[2]:
>>>
>>> reply[3]:
>>> MyThread-1[1]
>>
>> And the same output after the fix:
>>
>>> Sending command: cont
>>> reply[0]: >
>>> reply[1]: Method entered: "thread=MyThread-1", 
>>> java.util.Locale.getDefault(), line=910 bci=0
>>> reply[2]:
>>> reply[3]: MyThread-1[1]
>>
>> And this also matches the output we've been seeing on the unix 
>> platforms.
>>
>> thanks,
>>
>> Chris
>>



More information about the serviceability-dev mailing list