RFR (XS) JDK-8207745: serviceability/sa/TestJmapCore.java times out parsing a 4GB hprof file

[David Holmes]

LGTM.

Thanks,
David

On 27/09/2018 1:16 AM, Sharath Ballal wrote:
> Can I get one more review from a (R)eviewer please ?
> 
> Thanks,
> Sharath
> 
> 
> -----Original Message-----
> From: Sharath Ballal
> Sent: Wednesday, September 26, 2018 9:57 AM
> To: Jini Susan George; serviceability-dev
> Subject: RE: RFR (XS) JDK-8207745: serviceability/sa/TestJmapCore.java times out parsing a 4GB hprof file
> 
> Thanks for the review Jini.
> 
> 
> Thanks,
> Sharath
> 
> 
> -----Original Message-----
> From: Jini George
> Sent: Wednesday, September 26, 2018 9:42 AM
> To: Sharath Ballal; serviceability-dev
> Subject: Re: RFR (XS) JDK-8207745: serviceability/sa/TestJmapCore.java times out parsing a 4GB hprof file
> 
> Looks good to me.
> 
> Thanks,
> Jini.
> 
> On 9/24/2018 9:19 AM, Sharath Ballal wrote:
>> Hi,
>>
>> Pls review this test fix to add "-Xmx512m" to SA tests which create
>> either core file or heap dump, to avoid timeout due to large heap sizes.
>>
>> Bug id: https://bugs.openjdk.java.net/browse/JDK-8207745
>>
>> Webrev: http://cr.openjdk.java.net/~sballal/8207745/webrev.00/
>> <http://cr.openjdk.java.net/%7Esballal/8207745/webrev.00/>
>>
>> SA tests passed on Mach5 run.
>>
>> Thanks,
>>
>> Sharath
>>