[8u-backport] RFR: JDK-8164383 : jhsdb dumps core on Solaris 12 when loading dumped core

[Fairoz Matte]

Hi Jini, thanks for the review. May I get one more review for this?

Thanks,
Fairoz

> -----Original Message-----
> From: Jini George
> Sent: Friday, September 28, 2018 10:37 AM
> To: Fairoz Matte <fairoz.matte at oracle.com>; serviceability-
> dev at openjdk.java.net
> Subject: Re: [8u-backport] RFR: JDK-8164383 : jhsdb dumps core on Solaris 12
> when loading dumped core
> 
> This looks good to me, Fairoz.
> 
> Thanks,
> Jini.
> 
> On 9/26/2018 1:37 PM, Fairoz Matte wrote:
> > Hi Jini,
> >
> > Thanks for pointing out that, yes we cannot make that cleanup for JDK8.
> > Keeping it very simple and taking only changes required to fix
> > JDK-8164383 http://cr.openjdk.java.net/~fmatte/8164383/webrev.02/
> >
> > I have verified running "test/serviceability/sa/jmap-
> hashcode/Test8028623.java" test case (found from one of the duplicate issue
> of JDK-8164383).
> > Results are as expected before and after the patch on Solaris 12 and Solaris
> 10.
> >
> > Along with that, I have verified with Internal testing and found no
> > issues
> >
> > Thanks,
> > Fairoz
> >
> >> -----Original Message-----
> >> From: Jini George
> >> Sent: Tuesday, September 25, 2018 3:48 PM
> >> To: Fairoz Matte <fairoz.matte at oracle.com>; serviceability-
> >> dev at openjdk.java.net
> >> Subject: Re: [8u-backport] RFR: JDK-8164383 : jhsdb dumps core on
> >> Solaris 12 when loading dumped core
> >>
> >> Hi Fairoz,
> >>
> >> I took a better look at the changes and I realized that the cleanup
> >> related to SOLARIS_11_B159_OR_LATER would be valid for only JDK9 and
> >> later. Since
> >> JDK8 is supported for Solaris 10 too, I believe that the cleanup
> >> related changes done as a part of JDK-8164383 should not be done for
> JDK-8.
> >>
> >> Thanks!
> >> Jini.
> >>
> >> On 9/24/2018 7:21 PM, Fairoz Matte wrote:
> >>> Hi Jini,
> >>>
> >>>> -----Original Message-----
> >>>> From: Jini George
> >>>> Sent: Friday, September 21, 2018 4:07 PM
> >>>> To: Fairoz Matte <fairoz.matte at oracle.com>; serviceability-
> >>>> dev at openjdk.java.net
> >>>> Subject: Re: [8u-backport] RFR: JDK-8164383 : jhsdb dumps core on
> >>>> Solaris 12 when loading dumped core
> >>>>
> >>>> Hi Fairoz,
> >>>>
> >>>> This looks good to me. One nit which got missed out in the original
> >>>> change also is that in saproc.cpp, the following comments
> >>>>
> >>>>     452
> >>>>     453 // Pstack_iter() proc_stack_f callback prior to Nevada-B159
> >>>>
> >>>>     476 // Pstack_iter() proc_stack_f callback in Nevada-B159 or later
> >>>>     477 /*ARGSUSED*/
> >>>>
> >>>
> >>> I have incorporated above changes
> >>>
> >>>> would not be required anymore. And we would not need the wrapper
> to
> >>>> the callback routine fill_cframe_list() -- as in, we would need
> >>>> only one routine with the appropriate arguments passed. But you are
> >>>> free to ignore this since this was not done as a part of the original
> change.
> >>>
> >>> Removed wrapper_fill_cframe_list function and fill_cframe_list
> >>> function
> >> has been used directly.
> >>>
> >>> Please find the updated webrev
> >>> http://cr.openjdk.java.net/~fmatte/8164383/webrev.01/
> >>>
> >>> Thanks,
> >>> Fairoz
> >>>
> >>>>
> >>>> Thanks,
> >>>> Jini (Not a Reviewer).
> >>>>
> >>>>
> >>>>
> >>>> On 9/20/2018 7:06 PM, Fairoz Matte wrote:
> >>>>> Hi,
> >>>>>
> >>>>> Kindly review the backport of "JDK-8164383 : jhsdb dumps core on
> >>>>> Solaris 12 when loading dumped core" to 8u
> >>>>>
> >>>>> Webrev - http://cr.openjdk.java.net/~fmatte/8164383/webrev.00/
> >>>>>
> >>>>> JBS bug - https://bugs.openjdk.java.net/browse/JDK-8164383
> >>>>>
> >>>>> JDK9 changeset -
> >>>>> http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/ce3eaa22b582
> >>>>>
> >>>>> JDK9 review thread -
> >>>>> http://mail.openjdk.java.net/pipermail/serviceability-dev/2016-Oct
> >>>>> ob
> >>>>> er
> >>>>> /020543.html
> >>>>>
> >>>>> Thanks,
> >>>>> Fairoz
> >>>>>