RFR: JDK-8203364: Some serviceability/sa/ tests intermittently fail with java.io.IOException: LingeredApp terminated with non-zero exit code 3

Jean Christophe Beyler jcbeyler at google.com
Thu Apr 4 14:13:53 UTC 2019


Hi Gary,

Looks good to me. I agree that an error message would be beneficial too :)

Thanks!
Jc

On Thu, Apr 4, 2019 at 5:04 AM Gary Adams <gary.adams at oracle.com> wrote:

> I need a second reviewer for this minor update.
>
> On 4/2/19, 2:18 PM, Chris Plummer wrote:
> > On 4/2/19 11:11 AM, Gary Adams wrote:
> >> The test exits with 3 for the general Exception.
> >> I added 4 just to distinguish the return.
> >> I see 7 used earlier when the lockfile is not initialized.
> >>
> >> I could add a message, if you think it is useful.
> > Yes, I think it would be.
> >>
> >> The exit code is printed in stopApp(). line 377.
> > Ok. I was just wondering if specific error codes were being checked
> > for. It looks like that's not the case.
> >
> > thanks,
> >
> > Chris
> >>
> >> On 4/2/19, 1:58 PM, Chris Plummer wrote:
> >>> Hi Gary,
> >>>
> >>> I see various System.exit() calls with varying exit status. Is there
> >>> some place that documents them? What is 4?
> >>>
> >>> Any reason not to print the exception before doing the System.exit(4)?
> >>>
> >>> thanks,
> >>>
> >>> Chris
> >>>
> >>> On 4/2/19 4:50 AM, Gary Adams wrote:
> >>>> This proposed change allows a wider range of IOExceptions to be
> >>>> observed
> >>>> when a LingeredApp is being shutdown. It may not be just a
> >>>> NoSuchFileException.
> >>>> Botton line - if the lock file doesn't exist at the time the
> >>>> IOException
> >>>> is observed then the main application is terminating the test sequence
> >>>> and LingeredApp should end normally.
> >>>>
> >>>>   Webrev: http://cr.openjdk.java.net/~gadams/8203364/webrev/
> >>>>   Issue: https://bugs.openjdk.java.net/browse/JDK-8203364
> >>>
> >>>
> >>>
> >>
> >
> >
>
>

-- 

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20190404/d65e806e/attachment.html>


More information about the serviceability-dev mailing list