RFR (S) 8222491: jcmd can fail converting UTF8 output to strings

[David Holmes]

Hi Ralf, Christoph,

On 16/04/2019 3:54 pm, Langer, Christoph wrote:
> Hi Ralf,
> 
> looks good, thanks for fixing this. I can push it for you.
> 
> Can we please get another Reviewer's review? ��

Well I agree that the fix addresses the problem that has been described.

But I can't help but think there has to be a simpler way to pipe one 
inputstream into an outputstream without all the intermediary steps - ie 
creating strings. ??

Cheers,
David

> Thanks & Best regards
> Christoph
> 
>> -----Original Message-----
>> From: serviceability-dev <serviceability-dev-bounces at openjdk.java.net> On
>> Behalf Of Schmelter, Ralf
>> Sent: Montag, 15. April 2019 15:48
>> To: serviceability-dev at openjdk.java.net
>> Subject: [CAUTION] RFR (S) 8222491: jcmd can fail converting UTF8 output to
>> strings
>>
>> Hi,
>>
>> please review the small fix to jcmd. Instead of trying to convert only partially
>> read bytes to Strings by hand, we now use an InputStreamReader instead.
>>
>> webrev:
>> http://cr.openjdk.java.net/~rschmelter/webrevs/8222491/webrev.0/
>> bugreport: https://bugs.openjdk.java.net/browse/JDK-8222491
>>
>> Best regards,
>> Ralf