RFR(S) 8222935: Add forgotten files for ExceptionCheckingJniEnv

Jean Christophe Beyler jcbeyler at google.com
Thu Apr 25 02:53:24 UTC 2019


Thanks all, I fixed Serguei's issues and pushed it as it was apparently
breaking tier5 testing.

My sincere apologies again,
Jc

On Wed, Apr 24, 2019 at 6:16 PM Chris Plummer <chris.plummer at oracle.com>
wrote:

> Hi JC,
>
> Looks good.
>
> thanks,
>
> Chris
>
> On 4/24/19 4:42 PM, Jean Christophe Beyler wrote:
>
> Hi all,
>
> Submit repo actually failed on the first version due to some loss of
> precision assignments. And also there was a slight bug in the exception
> messaging handling, so this is now fixed in the webrev:
>
> This version passes the test and the submit repo:
> Webrev: http://cr.openjdk.java.net/~jcbeyler/8222935/webrev.01/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8222935
>
> Thanks for your help,
> Jc
>
>
> On Wed, Apr 24, 2019 at 11:10 AM Alex Menkov <alexey.menkov at oracle.com>
> wrote:
>
>> LGTM
>>
>> --alex
>>
>> On 04/24/2019 11:07, Jean Christophe Beyler wrote:
>> > Hi all,
>> >
>> > When pushing my fix for JDK-8213501, I did not push the added files
>> > which were the new test for the whole system.
>> >
>> > These were reviewed via the JDK-8213501
>> > (http://cr.openjdk.java.net/~jcbeyler/8213501/webrev.08/) fix but I'm
>> > just asking for a review again to add this webrev:
>> >
>> > Webrev: http://cr.openjdk.java.net/~jcbeyler/8222935/webrev.00/
>> > Bug: https://bugs.openjdk.java.net/browse/JDK-8222935
>> >
>> > My apologies for this... This has been sent to the submit repo in
>> parallel.
>> >
>> > Thanks,
>> > Jc
>>
>
>
> --
>
> Thanks,
> Jc
>
>
>

-- 

Thanks,
Jc
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20190424/a6665a3c/attachment.html>


More information about the serviceability-dev mailing list