PING: RFR: 8226204: SA: Refactoring for option processing in SALauncher

[Yasumasa Suenaga]

Thanks Chris!
I'm waiting for Serguei's review.


Yasumasa


On 2019/08/14 7:47, Chris Plummer wrote:
> Hi Yasumasa,
> 
> The changes look ok to me, although I've got to admit the language and library features used by toolMap are a bit beyond what I'm comfortable with (I'm one of those that find many uses of newer language and library feature to be more of a hindrance to understanding code than they are a benefit to simplifying or streamlining code). But I'm ok with it and assume it works as the reader would expect (after staring at it for a bit).
> 
> I likely won't be able to do any re-review if more changes are needed since I'll be out of the office for a while. I think Serguei is going to do the 2nd review, so assuming he's ok with it, and any additional changes are minor, you can still count me as a reviewer.
> 
> thanks,
> 
> Chris
> 
> On 8/10/19 4:14 AM, Yasumasa Suenaga wrote:
>> PING: Could you review it?
>>
>>>    JBS: https://bugs.openjdk.java.net/browse/JDK-8226204
>>>    webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8226204/webrev.00/
>>
>>
>> Yasumasa
>>
>>
>> On 2019/07/24 10:18, Yasumasa Suenaga wrote:
>>> Hi all,
>>>
>>> Please review this change:
>>>
>>>    JBS: https://bugs.openjdk.java.net/browse/JDK-8226204
>>>    webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8226204/webrev.00/
>>>
>>> This enhancement has been proposed in [1].
>>>
>>> SALauncher (jhsdb implementation) processes the option for each subcommand (e.g. jstack, hsdb).
>>> But they exist in many place with similar code.
>>> So there is some room for refactoring.
>>>
>>> This change has passed the tests on submit repo and serviceability/sa tests.
>>>
>>>
>>> Thanks,
>>>
>>> Yasumasa
>>>
>>>
>>> [1] https://mail.openjdk.java.net/pipermail/serviceability-dev/2019-June/028376.html
> 
>