RFR: JDK-8228547: accessibility errors in jvmti.html

[David Holmes]

Hi Alex,

Visually this appeared fine to me, so as long as the accessibility 
checking tool is happy then changes seem good.

Thanks,
David

On 17/08/2019 9:46 am, Alex Menkov wrote:
> Hi all,
> 
> Please review the change that fixes accessibility issues in generated 
> jvmti.html
> 
> There are 2 "general" accessibility issues ("content outside of a 
> region") - fixed by replacing <div role="banner"> with <header> and <div 
> role="main"> with <main>
> and huge number (5200+) of table issues:
> - no row or column header for cells;
> - table has only one column or row.
> Most of the tables was updated to have row and column headers,
> the tables which does not contain table data (like "Phase/Callback 
> Safe/Position/Since" block for functions) were converted to use <div>s.
> All table headers/descriptions were converted to <caption>.
> All cases when tables can has only one row/column are handled by xsl (if 
> there is no data for the table, <div>s are used).
> 
> jira: https://bugs.openjdk.java.net/browse/JDK-8228547
> 
> webrev: 
> http://cr.openjdk.java.net/~amenkov/jdk14/jvmti_html_accessibility/webrev/
> 
> generated doc:
> - old: 
> http://cr.openjdk.java.net/~amenkov/jdk14/jvmti_html_accessibility/0/jvmti.html 
> 
> - new: 
> http://cr.openjdk.java.net/~amenkov/jdk14/jvmti_html_accessibility/1/jvmti.html 
> 
> 
> Visually there are minimal changes (checked in Firefox, Chrome, IE)
> 
> specdiff: 
> http://cr.openjdk.java.net/~amenkov/jdk14/jvmti_html_accessibility/spectdiff/diff.html 
> 
> 
> --alex