RFR: 8229957: Harden pid verification in attach mechanism

[Yasumasa Suenaga]

Looks good!


Yasumasa (ysuenaga)

2019年8月22日(木) 2:38 Leonid Mesnik <leonid.mesnik at oracle.com>:

> Yasumasa, Severin
>
> Thank you, I updated condition. Agree that pid might be equal 1 for java
> in containers on linux and also might be for some specific configuration
> with other OS. Se let just check that it is at least positive.
>
> http://cr.openjdk.java.net/~lmesnik/8229957/webrev.01/
>
> Leonid
>
> On 8/21/19 7:45 AM, Severin Gehwolf wrote:
> > On Wed, 2019-08-21 at 23:22 +0900, Yasumasa Suenaga wrote:
> >> Hi Leonid,
> >>
> >> In case of Linux on Docker container, java might be run with PID=1.
> >> So I think `pid <= 1` is incorrect.
> > That's a very good point, Yasumasa. Nice catch.
> >
> > I believe changing the condition to < 1 would work.
> >
> > Thanks,
> > Severin
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20190822/9c5aed6d/attachment.html>