RFR: JDK-8228554: Accessibility errors in jdwp-protocol.html

Alex Menkov alexey.menkov at oracle.com
Mon Aug 26 17:01:30 UTC 2019


Hi Serguei,

The change is intentional - it seems to me that there were too many 
borders in the struct description tables. I thought about removing some 
of them (or making them thiner or changing color to gray).
I don't think absence of the lines makes comprehension of the structures 
harder.

--alex

On 08/26/2019 00:58, serguei.spitsyn at oracle.com wrote:
> Hi Alex,
> 
> I see one issue with new table format.
> For instance look at the table for "DisposeObjects Command (14)".
> Even a better example is "RedefineClasses Command (18)".
> In the old tables the indentation was highlighted with the vertical lines.
> It is missed in your version.
> 
> Thanks,
> Serguei
> 
> 
> On 8/23/19 16:54, Alex Menkov wrote:
>> Hi all,
>>
>> Please review the fix for
>> https://bugs.openjdk.java.net/browse/JDK-8228554
>>
>> webrev: 
>> http://cr.openjdk.java.net/~amenkov/jdk14/jdwp-protocol_accessibility/webrev/ 
>>
>>
>> generated docs:
>> old: 
>> http://cr.openjdk.java.net/~amenkov/jdk14/jdwp-protocol_accessibility/0/jdwp-protocol.html 
>>
>> new: 
>> http://cr.openjdk.java.net/~amenkov/jdk14/jdwp-protocol_accessibility/1/jdwp-protocol.html 
>>
>>
>> specdiff:
>> http://cr.openjdk.java.net/~amenkov/jdk14/jdwp-protocol_accessibility/spectdiff/diff.html 
>>
>>
>> Summary:
>> - "content outside of a region" issues:
>>   - <div role="banner"> replaced with with <header>,
>>   - <div role="main"> replaced with <main>;
>> - table issues:
>>   - added column headers to all tables;
>>   - for every row specified row header;
>>   - indentation with table "colspan" reimplemented by using CSS.
>>
>> --alex
> 


More information about the serviceability-dev mailing list